[Webkit-unassigned] [Bug 216172] [JSC] Use symbols as identifiers for class fields computed names storage

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=216172

--- Comment #22 from Caio Lima <ticaiolima at gmail.com> ---
Comment on attachment 412513
  --> https://bugs.webkit.org/attachment.cgi?id=412513
Use symbols as identifiers, v8

View in context: https://bugs.webkit.org/attachment.cgi?id=412513&action=review

Patch LGTM. I left a comment below.

> Source/WTF/wtf/text/SymbolRegistry.h:94
> +    CreateSymbol m_createSymbol { nullptr };

I'm wondering if it is really worth it have those 2 new members on `SymbolRegistry`. I'm neutral on `m_symbolType` but I'm not sold on `m_createSymbol`, since we could call either `RegisteredSymbolImpl::createPrivate` or `RegisteredSymbolImpl::create` directly on `symbolForKey`  based on `m_symbolType`.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201106/ef16f785/attachment.htm>