[Webkit-unassigned] [Bug 218562] [GTK][Regression][2.30] Application cannot override drag&drop callbacks

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=218562

Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #413169|commit-queue?               |commit-queue+
              Flags|                            |

--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 413169
  --> https://bugs.webkit.org/attachment.cgi?id=413169
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413169&action=review

> Source/WebKit/UIProcess/API/gtk/DropTargetGtk3.cpp:59
> -    g_signal_connect(m_webView, "drag-motion", G_CALLBACK(+[](GtkWidget*, GdkDragContext* context, gint x, gint y, guint time, gpointer userData) -> gboolean {
> +    g_signal_connect_after(m_webView, "drag-motion", G_CALLBACK(+[](GtkWidget*, GdkDragContext* context, gint x, gint y, guint time, gpointer userData) -> gboolean {

I guess this is not needed in GTK4, because apps wanting to override this can use the capture phase on GtkDropTargetAsync?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201106/559fd554/attachment-0001.htm>