[Webkit-unassigned] [Bug 218565] [css-grid] Move tests grid-columns-rows-get-set-multiple and grid-content-sized-columns-resolution to WPT folder
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 5 02:10:22 PST 2020
https://bugs.webkit.org/show_bug.cgi?id=218565
Manuel Rego Casasnovas <rego at igalia.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #413274|review? |review-
Flags| |
--- Comment #4 from Manuel Rego Casasnovas <rego at igalia.com> ---
Comment on attachment 413274
--> https://bugs.webkit.org/attachment.cgi?id=413274
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=413274&action=review
Thanks for doing this, just a minor change is required, the rest looks good to me.
> LayoutTests/ChangeLog:7
> +
I'd add here a small comment, explaining that these tests have been moved upstream in a Chromium change, linking the change or the WPT PR generated by the change.
> LayoutTests/imported/w3c/ChangeLog:12
> +
I believe we miss a change in "css/css-grid/parsing/w3c-import.log" to include the new tests.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201105/969aa21d/attachment.htm>
More information about the webkit-unassigned
mailing list