[Webkit-unassigned] [Bug 218566] JSC build fails on Big Sur 11.0.1 beta

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=218566

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #413183|review?                     |review+, commit-queue-
              Flags|                            |

--- Comment #5 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 413183
  --> https://bugs.webkit.org/attachment.cgi?id=413183
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413183&action=review

r=me

> Source/cmake/WebKitFindPackage.cmake:94
> +        # Apple just has a single tbd for ICU

Nit: Add period at the end of the comment.  (Not necessary to land, but you might want to make this change while fixing the ChangeLog.)

> ChangeLog:8
> +        * CMakeLists.txt:

Nit: Remove this line as this file is no longer changed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201104/b69b94df/attachment-0001.htm>