[Webkit-unassigned] [Bug 218566] JSC build fails on Big Sur 11.0.1 beta

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=218566

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #413161|review?                     |review-
              Flags|                            |

--- Comment #2 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 413161
  --> https://bugs.webkit.org/attachment.cgi?id=413161
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413161&action=review

r- for the cmake minimum version change.

> CMakeLists.txt:9
> -cmake_minimum_required(VERSION 3.10)
> +cmake_minimum_required(VERSION 3.18)

Is this needed to use the find_library() function?

I only have 3.17.x installed on my macOS 10.15.6 system, so I think this would break (Apple) folks using CMake on macOS.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201104/bd6ec644/attachment.htm>