[Webkit-unassigned] [Bug 218462] REGRESSION(r261570): [GTK] Drag of unknown type aborted on motion above WebView under X11

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=218462

--- Comment #1 from Milan Crha <mcrha at redhat.com> ---
The below backtrace is coming from the DropTarget constructor. If I understand it correctly, then the mouse cursor motion creates another WebView (because webkit asked for the selection data during the motion), for which Evolution prints the message. I do not think WebKit should ask the data during the drag operation, it should ask it only on the drop operation.

There is a comment in the sources:
    // WebCore needs the selection data to decide, so we need to preload the
    // data of targets we support. Once all data requests are done we start
    // notifying the web process about the DND events.

With respect of the notifications, you need to provide status of the drag, thus remove:

    if (operation == m_operation)
        return;

from void DropTarget::didPerformAction().

The backtrace of the second constructor:
   at _ZN6WebKit10DropTargetC2EP10_GtkWidget()
   by _ZL28webkitWebViewBaseConstructedP8_GObject()
   by _ZL24webkitWebViewConstructedP8_GObject()
   by web_view_constructed() at e-web-view.c:1524
   by mail_display_constructed() at e-mail-display.c:1614
   by g_object_new_with_custom_constructor() at gobject.c:2061
   by g_object_new_internal() at gobject.c:2089
   by g_object_new_valist() at gobject.c:2421
   by g_object_new() at gobject.c:1929
   by mail_printer_new_web_view() at e-mail-printer.c:341
   by e_mail_printer_print() at e-mail-printer.c:577
   by em_utils_print_messages_to_file() at em-utils.c:519
   by em_utils_selection_set_urilist() at em-utils.c:1085
   by ml_tree_drag_data_get() at message-list.c:2593
   by e_marshal_VOID__INT_POINTER_INT_OBJECT_BOXED_UINT_UINT() at e-marshal.c:1452
   by g_closure_invoke() at gclosure.c:815
   by signal_emit_unlocked_R() at gsignal.c:3747
   by g_signal_emit_valist() at gsignal.c:3498
   by g_signal_emit() at gsignal.c:3556
   by et_drag_data_get() at e-tree.c:2420
   by _gtk_marshal_VOID__OBJECT_BOXED_UINT_UINTv()
   by _g_closure_invoke_va() at gclosure.c:873
   by g_signal_emit_valist() at gsignal.c:3413
   by g_signal_emit_by_name() at gsignal.c:3594
   by gtk_drag_selection_get()
   by _gtk_marshal_VOID__BOXED_UINT_FLAGSv()
   by _g_closure_invoke_va() at gclosure.c:873
   by g_signal_emit_valist() at gsignal.c:3413
   by g_signal_emit_by_name() at gsignal.c:3594
   by gtk_selection_invoke_handler()
   by gtk_selection_convert()
   by _ZN6WebKit10DropTarget6acceptEj()
   by _ZZN6WebKit10DropTargetC4EP10_GtkWidgetENUlS2_P15_GdkDragContextiijPvE_4_FUNES2_S4_iijS5_()
   by _gtk_marshal_BOOLEAN__OBJECT_INT_INT_UINT()
   by g_closure_invoke() at gclosure.c:815
   by signal_emit_unlocked_R() at gsignal.c:3747
   by g_signal_emit_valist() at gsignal.c:3510
   by g_signal_emit_by_name() at gsignal.c:3594
   by gtk_drag_dest_motion()
   by _gtk_drag_dest_handle_event()
   by gtk_main_do_event()
   by _gdk_event_emit()
   by gdk_event_source_dispatch()
   by g_main_dispatch() at gmain.c:3322
   by g_main_context_dispatch() at gmain.c:3990
   by g_main_context_iterate() at gmain.c:4062
   by g_main_loop_run() at gmain.c:4253

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201104/69135a9a/attachment.htm>