[Webkit-unassigned] [Bug 218401] [GPU Process] Flush canvas displayList from doAfterUpdateRendering

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=218401

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #412939|review?                     |review-
              Flags|                            |

--- Comment #6 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 412939
  --> https://bugs.webkit.org/attachment.cgi?id=412939
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412939&action=review

> Source/WebCore/html/HTMLCanvasElement.cpp:375
> +#if ENABLE(GPU_PROCESS)
> +    if (m_context)
> +        addObserver(document());
> +#endif

This needs to be a runtime check not a compile-time check, and should only happen when we make a remote image buffer.

> Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp:2051
> +    if (buffer && buffer->renderingResourceIdentifier())

I don't think checking for a renderingResourceIdentifier is the right approach. Maybe add ImageBuffer::flushContextAsync() and just call it always, then specialize the remote image buffer to flush the display list etc.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201102/b6eaebc1/attachment.htm>