[Webkit-unassigned] [Bug 212524] [GTK] Bubblewrap sandbox lacks support for sndio

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=212524

--- Comment #5 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
(In reply to Haelwenn (lanodan) Monnier from comment #3)
> (In reply to Carlos Alberto Lopez Perez from comment #2)
> > Comment on attachment 400580 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=400580&action=review
> > > Source/WebKit/ChangeLog:11
> > > +        No new tests (OOPS!).
> > 
> > You have to remove this line and change it by something like "Covered by
> > existing tests"
> 
> Well there *is* no tests for sndio into the webkit bubblewrap sandbox so I'm
> not really sure what to write there.

I know, but you have to remove that line "No new tests (OOPS!)." to make our tooling happy. So saying something along with what I suggested is good enough. You can also say something like "Feature has been manually tested, there is currently not automatic tests for it"

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200529/922e6225/attachment.htm>