[Webkit-unassigned] [Bug 212425] New: webkit-patch create-revert cannot handle unicode reason

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=212425

            Bug ID: 212425
           Summary: webkit-patch create-revert cannot handle unicode
                    reason
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ysuzuki at apple.com

If we pass non-ascii reason text to this command, it fails.

Traceback (most recent call last):
  File "/home/yusukesuzuki/dev/OpenSource/Tools/Scripts/webkit-patch", line 80, in <module>
    main()
  File "/home/yusukesuzuki/dev/OpenSource/Tools/Scripts/webkit-patch", line 75, in main
    WebKitPatch(os.path.abspath(__file__)).main()
  File "/home/yusukesuzuki/dev/OpenSource/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 305, in main
    result = command.check_arguments_and_execute(options, args, self)
  File "/home/yusukesuzuki/dev/OpenSource/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 123, in check_arguments_and_execute
    return self.execute(options, args, tool) or 0
  File "/home/yusukesuzuki/dev/OpenSource/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 55, in execute
    self._sequence.run_and_handle_errors(tool, options, state)
  File "/home/yusukesuzuki/dev/OpenSource/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors
    self._run(tool, options, state)
  File "/home/yusukesuzuki/dev/OpenSource/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run
    step(tool, options).run(state)
  File "/home/yusukesuzuki/dev/OpenSource/Tools/Scripts/webkitpy/tool/steps/preparechangelogforrevert.py", line 62, in run
    message = self._message_for_revert(state["revision_list"], state["reason"], state["description_list"], reverted_bug_url_list, revert_bug_url)
  File "/home/yusukesuzuki/dev/OpenSource/Tools/Scripts/webkitpy/tool/steps/preparechangelogforrevert.py", line 48, in _message_for_revert
    message += "\"%s\"\n" % description_list[index]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 79: ordinal not in range(128)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200527/cd5d42e6/attachment.htm>