[Webkit-unassigned] [Bug 176119] [GTK][WPE] API for WebView audio mute support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=176119

--- Comment #57 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 400258
  --> https://bugs.webkit.org/attachment.cgi?id=400258
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400258&action=review

New version looks good, r=me for the first of two GTK reviewer approvals.

> Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:1279
> +     * It may still be playing, i.e. WebKitWebView:is-playing-audio may be TRUE.

%TRUE

> Tools/ChangeLog:26
> +2020-05-26  Jan-Michael Brummer  <jan.brummer at tabos.org>
> +
> +        [GTK][WPE] API for WebView audio mute support
> +        https://bugs.webkit.org/show_bug.cgi?id=176119
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * MiniBrowser/gtk/BrowserTab.c:
> +        (audioClicked):
> +        (audioMutedChanged):
> +        (browserTabConstructed):
> +        * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
> +        (testWebViewIsAudioMuted):
> +        (beforeAll):
> +
> +2020-05-12  Jan-Michael Brummer  <jan.brummer at tabos.org>
> +
> +        Add mute button to notebook title.
> +        https://bugs.webkit.org/show_bug.cgi?id=176119
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * MiniBrowser/gtk/BrowserTab.c:
> +        (audioClicked):
> +        (audioMutedChanged):
> +        (browserTabConstructed):

Careful not to duplicate the ChangeLog.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200526/06de1b9a/attachment.htm>