[Webkit-unassigned] [Bug 176119] [GTK][WPE] API for WebView audio mute support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=176119

--- Comment #54 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 399458
  --> https://bugs.webkit.org/attachment.cgi?id=399458
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399458&action=review

> Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:1276
> +     * WebKitWebView:is-audio-muted:

So we agreed on renaming from WebKitWebView:is-audio-muted to WebKitWebView:is-muted

> Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:1280
> +     * Whether the #WebKitWebView audio is muted from a page.
> +     * This property becomes %TRUE as soon as web content is muted. Otherwise
> +     * the property is set back to %FALSE.

Well Carlos doesn't like the current description because it is just not true. This say the property changes when web content is muted, but it is unrelated to the web content state, it's a view-level mute. That is, the property will not actually become %TRUE when the web content is muted.

How about: "Whether the #WebKitWebView audio is muted. When TRUE, web content will not be able to play audio."

What is its interaction with is-playing-audio? Is it possible for both is-audio-muted and is-playing-audio to be TRUE at the same time?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200526/0d2e008c/attachment-0001.htm>