[Webkit-unassigned] [Bug 212338] New: [WPE] Avoid possible WTR event timing going back in time and fix conversion from s to ms

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 24 20:35:02 PDT 2020


https://bugs.webkit.org/show_bug.cgi?id=212338

            Bug ID: 212338
           Summary: [WPE] Avoid possible WTR event timing going back in
                    time and fix conversion from s to ms
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WPE WebKit
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: lmoura at igalia.com
                CC: bugs-noreply at webkitgtk.org

WPE's EventSenderProxy stores the event time (double m_time) as the elapsed number of seconds like other ports, but the native wpe_input_*_event uses uint32_t. EventSenderProxy casts the former to the latter without adjusting neither to a "real" time (more below) nor from seconds to milliseconds (wpe_input_*_event's timing unit).

Also, when the event arrives in Source/WebKit/Shared/libwpe/WebEventFactory.cpp, WPE's implementation of wallTimeForEventTime will fallback to WallTime::now() if the timestamp is zero, using raw seconds otherwise. This can cause the WebEvents that started from zero having a WallTime in front of subsequent events that would come after a leapForward (for example, the event timestamps in fast/events/click-count.html)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200525/563efd2d/attachment.htm>


More information about the webkit-unassigned mailing list