[Webkit-unassigned] [Bug 176119] [GTK][WPE] API for WebView audio mute support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=176119

--- Comment #50 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Michael Catanzaro from comment #49)
> (In reply to Carlos Garcia Campos from comment #48)
> > I'm not sure to be honest. Maybe instead of a property that you think you
> > might monitor for changes in the page mute we could just add
> > webkit_web_view_mute() and webkit_web_view_is_muted()
> 
> Well the property is probably important because it allows using GBinding to
> sync UI to the state of the property.
> 
> > documenting that that
> > we are making the view muted, independently of the mute state of the media
> > elements. That way it's clear it's a user API only action, not something
> > that can be changed by the web content. And that it doesn't affect the
> > actual web contents either (media elements are not actually muted). What do
> > you think?
> 
> Of course, we should document this. I guess we could also rename from
> is-audio-muted to is-muted if you think that's more clear.

Yes, I think so. We should document that when media elements in a page are muted, is-playing-audio becomes FALSE and that changing is-muted doesn't affect the media element states, and is-playing-audio would still be TRUE even after setting is-muted to TRUE.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200521/4daa2096/attachment-0001.htm>