[Webkit-unassigned] [Bug 212126] [GTK4] Build error with gtk4 on PluginProcessMainUnix.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=212126

--- Comment #6 from Santosh Mahto <santosh.mahto at collabora.com> ---
(In reply to Adrian Perez from comment #5)
> Comment on attachment 399810 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=399810&action=review
> 
> > Source/WebKit/ChangeLog:8
> > +        * PluginProcess/unix/PluginProcessMainUnix.cpp:
> 
> NPAPI plug-in support is disabled for GTK4 builds. We are not planning
> to support them, given that all major browsers are phasing out the support
> (or have already).
> 
> > Source/WebKit/PluginProcess/unix/PluginProcessMainUnix.cpp:64
> >          gtk_init(nullptr, nullptr);
> 
> …anyway, instead of doing this, you should leave the call to gtk_init()
> unchanged and instead the <WebCore/GtkVersioning.h>, which has utility
> functions that avoid the need for preprocessor guards.


Thanks for review,
I will update the patch with WebCore/GtkVersioning.h inclusion, If you feel it should be part of main tree(at least until PluginProcessMainUnix.cpp code is removed), you can further review/merge it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200520/5a51bcb8/attachment.htm>