[Webkit-unassigned] [Bug 211844] JSDOMWindowBase m_windowCloseWatchpoints must be Ref<>

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=211844

Yusuke Suzuki <ysuzuki at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ysuzuki at apple.com

--- Comment #3 from Yusuke Suzuki <ysuzuki at apple.com> ---
(In reply to xc.o.c.1180 at gmail.com from comment #2)
> Test case is not practical, it depends on memory access.
> 
> First, JSDOMWindowBase must be destroyed before ProxyableAccessCase which
> holds its m_windowCloseWatchpoints, this step is possible.

I think this is possible while I don't come up with the test case.

> 
> Second, since WatchpointSet is reference counted, the memory which has
> m_windowCloseWatchpoints's reference counter must be 1, otherwise,
> ProxyableAccessCase does not destroy its m_additionalSet (JSDOMWindowBase's
> m_windowCloseWatchpoints) when itself is deleted. This step is not practical
> in test case.

The initial m_refCount of RefCounted object is 1. And when wrapping this with Ref<> initially at construction, we do not increment it because of this (this is called "adopt". See adoptRef).
So this does not matter.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200513/71bf4781/attachment.htm>