[Webkit-unassigned] [Bug 211844] JSDOMWindowBase m_windowCloseWatchpoints must be Ref<>

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 13 12:40:24 PDT 2020


--- Comment #1 from Chris Dumez <cdumez at apple.com> ---
(In reply to xc.o.c.1180 at gmail.com from comment #0)
> Created attachment 399266 [details]
> patch
> JSC WatchpointSet is reference counted, however m_windowCloseWatchpoints is
> just a member variable.
> ProxyableAccessCase holds on it, when JSDOMWindowBase is destroyed,
> m_additionalSet holds a dangling pointer.
> By the way, WatchpointSet constructor should be private.
> I can not build latest WebKit, please clean up the patch, add other stuffs,
> then commit it.
> Thanks.

We are unable to approve / commit patches without test cases.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200513/5453d93f/attachment.htm>

More information about the webkit-unassigned mailing list