[Webkit-unassigned] [Bug 208907] [GTK] graphics/GLContext.cpp fails compiling with error: ‘initializeOpenGLShims’ was not declared in this scope; did you mean ‘initializeOpenGLShimsIfNeeded’?

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=208907

--- Comment #6 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Trying to find when this broke... I'm not sure. That header was *added* to the file in r249909. Prior to that commit, it must have been included from some other header. The guards are clearly incorrect since the shims are initialized outside the USE(GLX) codepath, so your patch is an improvement at least.

(In reply to Mart Raudsepp from comment #4)
> Looking into this, I found that various OpenGLShims.h usages are quite
> different from each other in their conditionals. So some places assume it's
> only needed for GLX, while others don't know anything about ANGLE being a
> thing yet, etc.

Yeah I agree this seems to be pretty messed up. Needs to be investigated by graphics developers.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200513/27880e7b/attachment-0001.htm>