[Webkit-unassigned] [Bug 176119] [GTK][WPE] API for WebView audio mute support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=176119

--- Comment #32 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 399162
  --> https://bugs.webkit.org/attachment.cgi?id=399162
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399162&action=review

> Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:3198
> +void webkit_web_view_set_audio_muted(WebKitWebView* webView, gboolean muted)

This is weird, because is-audio-muted is a read-only property. I know this is not set_is_audio_muted, but it's still confusing.

> Source/WebKit/UIProcess/WebPageProxy.cpp:5982
> +bool WebPageProxy::isAudioMuted() const
> +{
> +    return (m_mutedState & MediaProducer::AudioIsMuted);
> +}

This could be in the header

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:5082
> +    send(Messages::WebPageProxy::IsPageMutedDidChange());

Do we really need to get notified back by the web process, I thought this was because setting muted might fail, but since this is called unconditionally, and the UI process is getting the value already set there, I don't think we need this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200513/e3873c3a/attachment.htm>