[Webkit-unassigned] [Bug 211711] WinCairo scores 1.00 on MotionMark benchmark since r261113

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 12 19:09:48 PDT 2020


--- Comment #6 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Created attachment 399227

  --> https://bugs.webkit.org/attachment.cgi?id=399227&action=review

MotionMark of WinCairo WK1 (r261577) (No updateRendering in WM_PAINT)

Why does WinCairo WK1 non-AC perform well for MotionMark even though it's also using a timer?
The reason seems that it calls Page::updateRendering twice in a single timer fire.
Once in WebView::paint, another in WebView::flushPendingGraphicsLayerChangesSoon.

I tried MotionMark with WinCairo WK1 again by applying a patch not to call Page::updateRendering in WebView::paint.
MotionMark score falled down to 1.39. (I don't know why it isn't 1.00)

diff --git a/Source/WebKitLegacy/win/WebView.cpp b/Source/WebKitLegacy/win/WebView.cpp
index fe7cb6a1d03..ec44027e06c 100644
--- a/Source/WebKitLegacy/win/WebView.cpp
+++ b/Source/WebKitLegacy/win/WebView.cpp
@@ -1285,7 +1285,7 @@ void WebView::paint(HDC dc, LPARAM options)

-    m_page->updateRendering();
+    //m_page->updateRendering();

     if (paintCompositedContentToHDC(dc)) {
         ::ValidateRect(m_viewWindow, nullptr);

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200513/2c538172/attachment.htm>

More information about the webkit-unassigned mailing list