[Webkit-unassigned] [Bug 211785] [Wheel event region] Add support for getting wheel event region from ScrollingTree

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=211785

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com

--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 399142
  --> https://bugs.webkit.org/attachment.cgi?id=399142
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399142&action=review

Is IntPoint right here? I’d like to understand better some day when it should be int, float, CGFloat/double, or LayoutUnit.

> Source/WebCore/page/scrolling/mac/ScrollingTreeMac.mm:194
> +    LockHolder lockHolder(m_layerHitTestMutex);

Does this lock need to be held all the way to the end? I don’t fully understand what is being guarded.

> Source/WebCore/page/scrolling/mac/ScrollingTreeMac.mm:208
> +    auto platformCALayer = PlatformCALayer::platformCALayerForLayer((__bridge void*)hitLayer);

Seems like we eventually need to fix this function so we don’t have to cast to void* to use it.

> Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.h:171
> +    const EventRegion* eventRegion() const override { return &m_eventRegion; }

final?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200512/7c1bf493/attachment-0001.htm>