[Webkit-unassigned] [Bug 176119] [GTK][WPE] API for WebView audio mute support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=176119

--- Comment #11 from Jan-Michael Brummer <jan.brummer at tabos.org> ---
> Let's say I have muted the audio for the web view using
> webkit_web_view_set_audio_muted(). That changes a property of the view, so
> it should stay muted if the view swaps to a new page. Now the user loads a
> new webpage from a different origin. The view's WebPageProxy stays the same,
> but the WebCore::Page backing it in the web process is swapped. The new page
> is probably not muted until we mute it by calling getPage(webView).setMuted.
> So we probably need to do that manually when the process swaps... right? Can
> you test this please? I bet the muted state gets lost if we don't have any
> code to persist it.

Tested youtube video and muted the page then switched over to a complete new origin and played a blog entry. Mute state is preserved.

> > Source/WebCore/ChangeLog:3
> > +        Add isPageMuteDidChange to inform about audio mute changes.
> 
> Just keep the title of the bug report here.

OK, will change it.

> > Source/WebCore/page/Page.cpp:1852
> >      forEachDocument([] (Document& document) {
> >          document.pageMutedStateDidChange();
> >      });
> > +
> > +    chrome().client().isPageMutedDidChange();
> >  }
> 
> I wonder what other code might call Page::setMuted? Is it something that
> will only be used by the web view level? If so, then this is fine. (If not,
> the API won't work be "sticky" as expected... we don't want anything besides
> webkit_web_view_set_audio_muted() to override the muted state.)

Haven't had a closer look at the internal calling as i took is-playing-audio as a base and added audio mute analog.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200511/374887c3/attachment.htm>