[Webkit-unassigned] [Bug 208907] graphics/GLContext.cpp fails compiling with error: ‘initializeOpenGLShims’ was not declared in this scope; did you mean ‘initializeOpenGLShimsIfNeeded’?

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=208907

--- Comment #4 from Mart Raudsepp <leio at gentoo.org> ---
Created attachment 398939

  --> https://bugs.webkit.org/attachment.cgi?id=398939&action=review

Patch to make non-X EGL full OpenGL builds succeed

I'm not happy about this patch, as it doesn't adjust things to be similar in all the places, but enough to get the build issue I was having fixed.

Looking into this, I found that various OpenGLShims.h usages are quite different from each other in their conditionals. So some places assume it's only needed for GLX, while others don't know anything about ANGLE being a thing yet, etc.
I don't know the context and maze of compile conditionals enough to really know how to do this properly, so meanwhile I'm going to try using this attached patch in Gentoo.

Note that this patch contains changes to another file issue as well, not just GLContext.cpp, as after fixing GLContext, the build reaches the next issue there.

I'm going to also have it build various different build configurations in the background on a big aarch64 box; if I don't report back here, all of those succeed with this patch included. Otherwise I'll have to update the patch to make all the build combinations we try to support work, and will post it here as well for consideration or ideas.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200509/82c34300/attachment.htm>