[Webkit-unassigned] [Bug 211662] Remove HAVE_UI_SCROLL_VIEW_INDICATOR_FLASHING_SPI

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat May 9 08:38:53 PDT 2020


https://bugs.webkit.org/show_bug.cgi?id=211662

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com
 Attachment #398920|review?, commit-queue?      |review+, commit-queue+
              Flags|                            |

--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 398920
  --> https://bugs.webkit.org/attachment.cgi?id=398920
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398920&action=review

> Source/WebKit/ChangeLog:12
> +        Remove this platform conditional and unconditionally use -[UIScrolView _flashScrollIndicatorsForAxes:
> +        persistingPreviousFlashes:]. All supported platforms with UIScrollView have this SPI, and the conditional
> +        was excluding Mac Catalyst, making WKKeyboardScrollViewAnimator send a message to its scroll view that
> +        is no longer implemented.

Seems like the headline here is fixing the bug on Mac Catalyst; a crash maybe?

Removing the HAVE macro is the less important half of this, as grateful as I am to have that cleaned up too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200509/adc7b52b/attachment.htm>


More information about the webkit-unassigned mailing list