[Webkit-unassigned] [Bug 211449] Regression (iOS 13.4, r249142): WKWebView.loading is never reset after a Back navigation in an iframe

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=211449

Ali Juma <ajuma at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cgarcia at igalia.com
            Summary|Regression (iOS 13.4):      |Regression (iOS 13.4,
                   |WKWebView.loading is never  |r249142): WKWebView.loading
                   |reset after a Back          |is never reset after a Back
                   |navigation in an iframe     |navigation in an iframe

--- Comment #2 from Ali Juma <ajuma at chromium.org> ---
This is happening because PageLoadState::setPendingAPIRequest is called during WebPageProxy::goToBackForwardItem, but the pending API request is never cleared. In WebPageProxy::didStartProvisionalLoadForFrameShared, |navigation| is null, so we don't call PageLoadState::clearPendingAPIRequest.

The |navigation| is null because in WebPageProxy::goToBackForwardItem, we only create an API::Navigation if the target item isn't considered same-document wrt the current item.

So this bug is a regression from r249142, which changed WebPageProxy::didStartProvisionalLoadForFrameShared to only call clearPendingAPIRequest if |navigation| is non-null.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200508/7ac86c36/attachment.htm>