[Webkit-unassigned] [Bug 210685] REGRESSION(r251875): Crash in JSC::StructureIDTable::get on ppc64le: gcSafeMemcpy broken on JSVALUE64 platforms other than x86_64 and aarch64

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 7 11:29:20 PDT 2020


https://bugs.webkit.org/show_bug.cgi?id=210685

Daniel Kolesa <daniel at octaforge.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #398740|0                           |1
        is obsolete|                            |
 Attachment #398760|0                           |1
        is obsolete|                            |

--- Comment #38 from Daniel Kolesa <daniel at octaforge.org> ---
Created attachment 398767

  --> https://bugs.webkit.org/attachment.cgi?id=398767&action=review

updated to use compile-time guards

This updates the patch to use compile-time guards. The second USE(JSVALUE64) was not necessary, since the whle thing is wrapped in USE(JSVALUE64) above that, so instead I replaced it with arch guards, which effectively caused the slow path to be taken for other JSVALUE64 archs always (plain memcpy fallback for non-JSVALUE64 works as before).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200507/7da1c259/attachment-0001.htm>


More information about the webkit-unassigned mailing list