[Webkit-unassigned] [Bug 211539] SIGILL @ WebCore::Shape::createRasterShape -- DOS ASAN

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=211539

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #398689|review?, commit-queue?      |review-, commit-queue-
              Flags|                            |

--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 398689
  --> https://bugs.webkit.org/attachment.cgi?id=398689
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398689&action=review

> Source/WebCore/rendering/shapes/Shape.cpp:196
> +        // RELEASE_ASSERT(imageData && imageData->data());

Please don't check in commented out code.

> Source/WebCore/rendering/shapes/Shape.cpp:197
> +        if (imageData && imageData->data()) {

Make this an early return.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200507/5586b2b3/attachment.htm>