[Webkit-unassigned] [Bug 210685] REGRESSION(r251875): Crash in JSC::StructureIDTable::get on ppc64le

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=210685

--- Comment #24 from Trung LE <trung.le at ruby-journal.com> ---
(In reply to Daniel Kolesa from comment #23)
> Created attachment 398740 [details]
> Patch to fix the regression
> 
> To quote the commit message:
> 
> The problem at hand here is that the control flow is wrong. As it was, we'd
> do something like:
> 
> ```
> if (bytes <= smallCutoff) {
>     slow path
> } else if (aarch64 || bytes <= mediumCutoff) {
>     either x86_64 path, aarch64 path or slow path
> } else {
>     assert(x86_64)
>     do x86_64 path, or nothing on other archs
> }
> ```
> 
> That means everything on non-x86_64/aarch64 that tried to memcpy more than
> mediumCutoff would end up doing nothing.
> 
> Fix the code so that slow path is taken automatically always if running
> non-x86_64/aarch64 architectures. Remove the #else in the mediumCutoff
> branch as that is now never taken.

Good catch. I can confirm that patch addresses the regression.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200507/c75c0fa0/attachment.htm>