[Webkit-unassigned] [Bug 211528] [Conditional=] not working for operations in WebGLRenderingContextBase.idl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=211528

--- Comment #6 from Sergio Villar Senin <svillar at igalia.com> ---
(In reply to Sergio Villar Senin from comment #5)
> OK I think I found a way to "fix" it. I am not not an expert on bindings
> generators so I am not sure whether what I am doing is an unsupported
> configuration, a limitation of the generator or just a bug in the IDL.
> 
> So if I remove the Conditional in the Base interface then everything works
> fine. The TestOperationConditional is properly generated. The Condition1
> guards all the code (as if it were specified in the base class and
> Condition2 guards the method that specified its own conditional.
> 
> Using the same fix for 211506 (i.e. removing Conditional=WEBGL from
> WebGLRenderingContextBase.idl) makes the build succeed.

After checking the WebGL example again I think that Darin is right. The generator is working fine as it's guarding the base class methods with the base class conditional (while the whole file is guarded by the derived interface conditional). The problem is that the generator should also add the operation specific conditional for the operation.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200507/77b4bb53/attachment.htm>