[Webkit-unassigned] [Bug 211512] Add basic support for generating accurate wheel event listener region

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=211512

--- Comment #4 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 398614
  --> https://bugs.webkit.org/attachment.cgi?id=398614
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398614&action=review

>> Source/WebCore/rendering/style/StyleRareInheritedData.h:158
>> +    unsigned eventListenerRegionTypes : 2; // OptionSet<EventListenerRegionType>
> 
> It's going to be really easy to forgot to change this when we add more EventListenerRegionType bits. I think maybe just eat the 8 bits right now, or add a compile-time assert that things will fit.

Patch is ok as is. No change needed.

Just for me: Could this storage also be used to track the editable region? Usually only elements with userModify != ReadOnly are in that region, but there's one except for HTMLTextFormControl elements that is currently handled by plumbing an overrideUserModifyIsEditable book through EventRegionContext::unite(). This storage could be used to eliminate that bool. I didn't want to add storage to every element's style before, but now that this storage exists it could be used. Just a thought....

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200506/fca6dc38/attachment.htm>