[Webkit-unassigned] [Bug 209432] Add Clobberize validator for clobber top.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=209432

--- Comment #15 from Keith Miller <keith_miller at apple.com> ---
(In reply to Yusuke Suzuki from comment #10)
> Comment on attachment 394536 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=394536&action=review
> 
> > Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:1863
> > +            auto scratch = m_jit.scratchRegister();
> > +            m_jit.load8(&vm().didEnterVM, scratch);
> > +            auto ok = m_jit.branchTest32(MacroAssembler::Zero, scratch);
> 
> Why not using branchTest8() with AbsoluteAddress?
> 
> > Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:1906
> > +                auto scratch = m_jit.scratchRegister();
> > +                m_jit.load8(&vm().didEnterVM, scratch);
> > +                auto ok = m_jit.branchTest32(MacroAssembler::Zero, scratch);
> 
> Why not using branchTest8 with AbsoluteAddress?

Whoops missed this comment will add in follow up.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200505/4efd83ea/attachment.htm>