[Webkit-unassigned] [Bug 211388] New: Code in ResourceLoadStatisticsDatabaseStore treats no data as an error

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=211388

            Bug ID: 211388
           Summary: Code in ResourceLoadStatisticsDatabaseStore treats no
                    data as an error
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit Misc.
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: bfulgham at webkit.org

While debugging another problem, I noticed that this code in ResourceLoadStatisticsDatabaseStore::hasHadUserInteraction:

    if (m_hadUserInteractionStatement.bindText(1, domain.string()) != SQLITE_OK
        || m_hadUserInteractionStatement.step() != SQLITE_ROW) {
        RELEASE_LOG_ERROR_IF_ALLOWED(m_sessionID, "%p - ResourceLoadStatisticsDatabaseStore::m_hadUserInteractionStatement failed, error message: %{private}s", this, m_database.lastErrorMsg());

This generates error logging for the expected case that a particular domain did not have user interaction.

We should avoid generating logging for normal program flow.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200504/4460105a/attachment.htm>