[Webkit-unassigned] [Bug 209465] [Curl] Proxy setting API does not work until Network process starts.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 31 13:50:38 PDT 2020


--- Comment #6 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 394356
  --> https://bugs.webkit.org/attachment.cgi?id=394356

View in context: https://bugs.webkit.org/attachment.cgi?id=394356&action=review

> Source/JavaScriptCore/ChangeLog:3
> +        [Curl] Proxy setting API does not working until Network process starts.

working → work
Remove the period. Let's follow the majority style.
This sentence doesn't make send to me. Do you mean "Proxy setting API does not work if Network process isn't started"?

> Tools/TestWebKitAPI/Tests/WebKit/curl/HTTPServer.cpp:40
> +    auto& endpoint = Inspector::RemoteInspectorSocketEndpoint::singleton();

I don't think it's a good idea to use Inspector::RemoteInspectorSocketEndpoint here.
Why don't you use Tools/TestWebKitAPI/TCPServer.cpp?

> Tools/TestWebKitAPI/Tests/WebKit/curl/HTTPServer.h:69
> +class HTTPServer final : public RemoteInspectorSocketEndpoint::Listener {

Do you know there is already TestWebKitAPI::HTTPServer class in Tools/TestWebKitAPI/cocoa/HTTPServer.mm?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200331/c682f0d0/attachment.htm>

More information about the webkit-unassigned mailing list