[Webkit-unassigned] [Bug 209805] [GTK] Bring back support for rendering scrollbars using the system appearance

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=209805

Michael Catanzaro <mcatanzaro at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mcatanzaro at gnome.org

--- Comment #3 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 395032
  --> https://bugs.webkit.org/attachment.cgi?id=395032
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395032&action=review

I've skimmed over the WebCore changes, since they are mostly restoring previous code.

> Source/WebKit/ChangeLog:9
> +        Add WebKitWebContext:use-system-appearance-for-scrollbars property. It's enabled by default to keep backwards
> +        compatibility.

Why? Would an app ever really want to change this setting? For GTK 3, I think every app wants to use it, and no apps would want to turn it off. For GTK 4, there's no way to make it work, so every app will need to have it off.  So I don't think the new property is needed.

> Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp:539
> +     * This is enabled by default for backwards compatibility, but it's only
> +     * recommened to use when the application includes other widgets to ensure
> +     * consistency, or when consistency with other applications is required too.

I can't think of any reason to turn it off...? Isn't consistency with other applications always required for GTK? I think so.

> Tools/ChangeLog:8
> +        Do not use system appearance for scrollbars in MiniBrowser and unit tests.

Hm, I guess we could find a private way to disable the themed scrollbars for layout tests? Something that doesn't require exposing public API?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200331/4c74add4/attachment.htm>