[Webkit-unassigned] [Bug 207119] Enable offlineasm debug annotations for GCC

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=207119

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com

--- Comment #34 from Darin Adler <darin at apple.com> ---
Comment on attachment 395039
  --> https://bugs.webkit.org/attachment.cgi?id=395039
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395039&action=review

> Source/WTF/wtf/Compiler.h:388
> +/* NO_REORDER */
> +#if !defined(NO_REORDER) && COMPILER(GCC)
> +#define NO_REORDER __attribute__((__no_reorder__))
> +#endif

Inconsistent to include a comment for NO_REORDER and not on MARKER_SYMBOL.

Also, all the other comments (except for UNUSED_VARIABLE) have blank lines after them.

Overkill to define a macro for NO_REORDER and use that macro in only one place, also under a COMPILE(GCC) conditional. I would not add this macro.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200331/cc4d180a/attachment.htm>