[Webkit-unassigned] [Bug 209465] [Curl] Proxy setting API does not work until Network process starts.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=209465

--- Comment #4 from Takashi Komori <Takashi.Komori at sony.com> ---
(In reply to Basuke Suzuki from comment #3)
> Comment on attachment 394356 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=394356&action=review
> 
> This is an informal review.
> 
> > Tools/TestWebKitAPI/Tests/WebKit/curl/Proxy.cpp:98
> > +    auto [proxyServer, proxyURL] = createServer("", 59001, "Respond from proxy server");
> 
> I cannot follow the logic. It seems this is the test for proxy server
> setting and these two `createServer` denote real http and proxy server for
> test environment, right? Where the logic to implement proxying?

When a browser connects via proxy it send a request line to the proxy as almost same as direct connection, and gets response from the proxy.
Whether using proxy or not, request and response sequence is almost same (The request line differs).
So just checking responses we can't distinct whether the responses come directly or via proxy.

In this test we use the behavior that a browser always connects to the proxy server when proxy is set.
If proxy setting works, the browser connects to specified proxy server otherwise it connects to specified URL directly.
We can check the response is from proxy or not by only checking response.

In EnableProxyBeforeLoading test, if proxy server is set to http://127.0.0.1:59001 WKPageLoadURL always connects to it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200331/c42e965d/attachment.htm>