[Webkit-unassigned] [Bug 209712] New: REGRESSION (r257867): [GPUP] Use-after-move in RemoteCDMInstance::createSession()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=209712

            Bug ID: 209712
           Summary: REGRESSION (r257867): [GPUP] Use-after-move in
                    RemoteCDMInstance::createSession()
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit2
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ddkilzer at webkit.org
                CC: eric.carlson at apple.com, jer.noble at apple.com

Use-after-move in RemoteCDMInstance::createSession() of `id` parameter:

RefPtr<WebCore::CDMInstanceSession> RemoteCDMInstance::createSession()
{
    if (!m_factory)
        return nullptr;

    RemoteCDMInstanceSessionIdentifier id;
    m_factory->gpuProcessConnection().connection().sendSync(Messages::RemoteCDMInstanceProxy::CreateSession(), Messages::RemoteCDMInstanceProxy::CreateSession::Reply(id), m_identifier);
    if (!id)
        return nullptr;
    auto session = RemoteCDMInstanceSession::create(makeWeakPtr(m_factory.get()), WTFMove(id));
    m_factory->addSession(id, session.copyRef());
    return session;
}

This regressed in:

Bug 208090: [GPUP] Implement Modern EME API in the GPU Process
<https://bugs.webkit.org/show_bug.cgi?id=208090>
<rdar://problem/59955230>
<https://trac.webkit.org/changeset/257867>

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200329/dc24cabc/attachment-0001.htm>