[Webkit-unassigned] [Bug 209607] Add SPI to specify whether file upload panels are uploading to an enterprise-managed destination

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=209607

--- Comment #6 from David Quesada <david_quesada at apple.com> ---
(In reply to Darin Adler from comment #5)
> Comment on attachment 394631 [details]
> Patch for landing
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=394631&action=review
> 
> > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:6611
> > +    auto webView = _webView.get();
> > +    id <WKUIDelegatePrivate> uiDelegate = static_cast<id <WKUIDelegatePrivate>>([webView UIDelegate]);
> > +    return [uiDelegate respondsToSelector:@selector(_webView:fileUploadPanelContentIsManagedWithInitiatingFrame:)] && [uiDelegate _webView:webView.get() fileUploadPanelContentIsManagedWithInitiatingFrame:wrapper(API::FrameInfo::create(WTFMove(_frameInfoForFileUploadPanel), _page.get()))];
> 
> Gotta admit I am surprised we can call _webView.get() and then call get()
> again on that!

Yup. The first get() converts from a WeakObjCPtr to RetainPtr, then the second get() returns the raw pointer.

> 
> Also, sorry I suggested the && but didn’t point out the cool way to format
> it:
> 
>     return [uiDelegate
> respondsToSelector:@selector(_webView:
> fileUploadPanelContentIsManagedWithInitiatingFrame:)]
>         && [uiDelegate _webView:webView.get()
> fileUploadPanelContentIsManagedWithInitiatingFrame:wrapper(API::FrameInfo::
> create(WTFMove(_frameInfoForFileUploadPanel), _page.get()))];

I like that formatting better. I'll use it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200326/f1e8dd25/attachment.htm>