[Webkit-unassigned] [Bug 209607] Add SPI to specify whether file upload panels are uploading to an enterprise-managed destination

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=209607

--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 394631
  --> https://bugs.webkit.org/attachment.cgi?id=394631
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=394631&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:6611
> +    auto webView = _webView.get();
> +    id <WKUIDelegatePrivate> uiDelegate = static_cast<id <WKUIDelegatePrivate>>([webView UIDelegate]);
> +    return [uiDelegate respondsToSelector:@selector(_webView:fileUploadPanelContentIsManagedWithInitiatingFrame:)] && [uiDelegate _webView:webView.get() fileUploadPanelContentIsManagedWithInitiatingFrame:wrapper(API::FrameInfo::create(WTFMove(_frameInfoForFileUploadPanel), _page.get()))];

Gotta admit I am surprised we can call _webView.get() and then call get() again on that!

Also, sorry I suggested the && but didn’t point out the cool way to format it:

    return [uiDelegate respondsToSelector:@selector(_webView:fileUploadPanelContentIsManagedWithInitiatingFrame:)]
        && [uiDelegate _webView:webView.get() fileUploadPanelContentIsManagedWithInitiatingFrame:wrapper(API::FrameInfo::create(WTFMove(_frameInfoForFileUploadPanel), _page.get()))];

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200326/341b4f99/attachment-0001.htm>