[Webkit-unassigned] [Bug 209607] Add SPI to specify whether file upload panels are uploading to an enterprise-managed destination

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=209607

--- Comment #3 from David Quesada <david_quesada at apple.com> ---
(In reply to Darin Adler from comment #2)
> Comment on attachment 394626 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=394626&action=review
> 
> > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:6609
> > +    auto webView = _webView.get();
> 
> A little strange to make this local variable but only use it once.

It's used twice -- on line 6610 to call -UIDelegate, and again on line 6612 for the first parameter of _webView:fileUpload...

> 
> > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:6614
> > +    if ([uiDelegate respondsToSelector:@selector(_webView:fileUploadPanelContentIsManagedWithInitiatingFrame:)])
> > +        return [uiDelegate _webView:webView.get() fileUploadPanelContentIsManagedWithInitiatingFrame:wrapper(API::FrameInfo::create(WTFMove(_frameInfoForFileUploadPanel), _page.get()))];
> > +
> > +    return NO;
> 
> I would have used && here.

Sure.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200326/2cef10f7/attachment.htm>