[Webkit-unassigned] [Bug 209590] REGRESSION (r254669): Expand media button doesn't work on first try on photos on reddit.com

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 26 10:28:42 PDT 2020


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
                 CC|                            |darin at apple.com
 Attachment #394606|review?                     |review+
              Flags|                            |

--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 394606
  --> https://bugs.webkit.org/attachment.cgi?id=394606

View in context: https://bugs.webkit.org/attachment.cgi?id=394606&action=review

> Source/WebCore/rendering/RenderReplaced.cpp:597
> +        // For images with explicit width/height this updates the instrinsic size as a side effect.
> +        computeAspectRatioInformationForRenderBox(embeddedContentBox(), constrainedSize, intrinsicRatio);

Seems obviously a good fix for now.

Are we happy with this side effect relationship here for the longer term?

Also, what guarantees embeddedContentBox() is not nullptr?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200326/9f88564c/attachment.htm>

More information about the webkit-unassigned mailing list