[Webkit-unassigned] [Bug 207119] Enable offlineasm debug annotations for GCC

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=207119

--- Comment #15 from Konstantin Tokarev <annulen at yandex.ru> ---
Comment on attachment 394363
  --> https://bugs.webkit.org/attachment.cgi?id=394363
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394363&action=review

>>> Source/JavaScriptCore/CMakeLists.txt:149
>>> +  set(CMAKE_CXX_COMPILER_LAUNCHER "${JavaScriptCore_SCRIPTS_SOURCES_DIR}/cxx-wrapper")
>> 
>> This will conflict with ccache. Maybe append to ${CMAKE_CXX_COMPILER_LAUNCHER} ?
> 
> Good point.
> But i think it should prepend (not append). The shell script wrapper should execute before than ccache.
> Otherwise ccache will think the shell script its the compiler and would cache the hash of the shell script instead of hashing the hash of the real compiler.

Indeed. While actual compiler doesn't produce .o file here, ccache should still be able to cache generated assembly file.

>>> Source/JavaScriptCore/Scripts/postprocess-asm:1
>>> +#!/usr/bin/env ruby
>> 
>> Script is missing license header. Also I heard there were problems with /usr/bin/env shebangs in some distros
> 
> That its a guideline fedora has for shipping executable scripts in fedora packages.
> This is a build script, not part of what gets installed, so its ok.
> See bug 208970

Is generate generate-gtkdoc installed? I thought it was also build-only.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200324/b868ecfa/attachment.htm>