[Webkit-unassigned] [Bug 209278] [GTK][WPE] REGRESSION(r258626): flatpak is used even when WEBKIT_JHBUILD is set

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=209278

Philippe Normand <pnormand at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pnormand at igalia.com
 Attachment #393972|review?                     |review-
              Flags|                            |

--- Comment #2 from Philippe Normand <pnormand at igalia.com> ---
Comment on attachment 393972
  --> https://bugs.webkit.org/attachment.cgi?id=393972
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393972&action=review

> Tools/ChangeLog:9
> +        This happens when using an external jhbuild, because shouldUseFlatpak() assumes that no command prefix always
> +        means flatpak.

What's failing exactly?

> Tools/Scripts/webkitdirs.pm:2176
> +    if (defined $ENV{'WEBKIT_JHBUILD'}) {

The env var value should be checked.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200319/27d0fcf4/attachment-0001.htm>