[Webkit-unassigned] [Bug 208913] [Curl] Add an API returns description of verification errors.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=208913

--- Comment #3 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 393229
  --> https://bugs.webkit.org/attachment.cgi?id=393229
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393229&action=review

> Tools/MiniBrowser/win/WebKitBrowserWindow.cpp:369
> +    auto certificateInfo = WKProtectionSpaceCopyCertificateInfo(protectionSpace);

Don't remove `adoptWK`. It will leak.

> Tools/MiniBrowser/win/WebKitBrowserWindow.cpp:371
> +    auto description = WKCertificateInfoCopyVerificationErrorDescription(certificateInfo);

Use adoptWK for the return value of *Copy* API. It will leak.

> Tools/TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp:93
> +    ASSERT_TRUE(WKStringIsEqualToUTF8CString(WKCertificateInfoCopyVerificationErrorDescription(certificateInfo.get()), "ok"));

The return value of WKCertificateInfoCopyVerificationErrorDescription leaks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200317/e11d2a36/attachment.htm>