[Webkit-unassigned] [Bug 208612] Resource Load Statistics: Keep a count of resource loads per day

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=208612

Chris Dumez <cdumez at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #392506|review?                     |review-
              Flags|                            |

--- Comment #4 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 392506
  --> https://bugs.webkit.org/attachment.cgi?id=392506
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392506&action=review

> Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:1307
> +    postTask([this, numberOfDays = WTFMove(numberOfDays), completionHandler = WTFMove(completionHandler)]() mutable {

No need to WTFMove() an unsigned

> Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:1317
> +            postTaskReply([resourceLoadCountPerDay = WTFMove(resourceLoadCountPerDay), completionHandler = WTFMove(completionHandler)]() mutable {

ditto

> Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:1318
> +                completionHandler(WTFMove(resourceLoadCountPerDay));

ditto

> Source/WebKit/Shared/WebCoreArgumentCoders.cpp:2756
> +    // Transient stats

WebKit comments need to end with a period.

> Source/WebKit/Shared/WebCoreArgumentCoders.cpp:2859
> +    // Transient stats

WebKit comments need to end with a period.

> Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:552
> +    completionHandler();

Dont you need to pass a parameter here?

> Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:887
> +    if (!canSendMessage()) {

Should not be needed.

> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:1526
> +            process->getResourceLoadCountPerDayForPastDays(m_sessionID, numberOfDays, WTFMove(completionHandler));

use after move of completionHandler if there is more than one process pool with a network process.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200305/5d7b098a/attachment.htm>