[Webkit-unassigned] [Bug 208442] [GTK][WPE] Fix current time and duration formatting in media controls

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=208442

--- Comment #5 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Xabier Rodríguez Calvar from comment #4)
> (In reply to Carlos Garcia Campos from comment #3)
> > (In reply to Xabier Rodríguez Calvar from comment #2)
> > > Comment on attachment 392128 [details]
> > > Patch
> > > 
> > > View in context:
> > > https://bugs.webkit.org/attachment.cgi?id=392128&action=review
> > > 
> > > > Source/WebCore/Modules/mediacontrols/mediaControlsAdwaita.js:411
> > > > +        else if (duration < 10 * 60) /* Ten minutes */
> > > > +            this.timeDigitsCount = 3;
> > > 
> > > I personally dislike having this on a time display. I would strongly
> > > recommend you remove this or run it thru more people who can give an opinion
> > > on this.
> > 
> > What do you mean? You don't like m:ss and h:mm:ss?
> 
> I don't like m:ss but I don't mind h:mm:ss. That was the design choice and I
> don't see a reason why it should not be respected now as well.

For consistency with other browsers, GNOME and some other popular video players.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200303/b7429440/attachment.htm>