[Webkit-unassigned] [Bug 207664] WebKit support for Apple Pay Buttons with custom corner radii

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 2 17:37:38 PST 2020


https://bugs.webkit.org/show_bug.cgi?id=207664

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |simon.fraser at apple.com

--- Comment #14 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 390799
  --> https://bugs.webkit.org/attachment.cgi?id=390799
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390799&action=review

> LayoutTests/ChangeLog:18
> +        * platform/mac-highsierra/http/tests/ssl/applepay/ApplePayButton-expected.png:
> +        * platform/mac-highsierra/http/tests/ssl/applepay/ApplePayButton-expected.txt:
> +        * platform/mac/http/tests/ssl/applepay/ApplePayButton-expected.png:
> +        * platform/mac/http/tests/ssl/applepay/ApplePayButton-expected.txt:
> +        * platform/mac/http/tests/ssl/applepay/ApplePayButtonV4-expected.png:
> +        * platform/mac/http/tests/ssl/applepay/ApplePayButtonV4-expected.txt:

We don't run pixel tests, so these tests are useless. You need to concoct some reference tests with transforms and marks to detect the kind of corner rendering.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200303/8e8bc39f/attachment.htm>


More information about the webkit-unassigned mailing list