[Webkit-unassigned] [Bug 208397] ASSERT(m_column != unsetColumnIndex) in RenderTable::cellBefore

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 2 09:01:01 PST 2020


--- Comment #5 from Doug Kelly <dougk at apple.com> ---
(In reply to zalan from comment #2)
> Comment on attachment 392025 [details]
> Patch
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=392025&action=review
> > Source/WebCore/ChangeLog:4
> > +        https://bugs.webkit.org/show_bug.cgi?id=208397
> radar# please.
> > Source/WebCore/ChangeLog:10
> > +        When inserting a cell into a table row which is not visible, this can lead to part of the rendering being triggered
> > +        before layout is complete.  Instead, mark the layer as dirty using dirtyVisibleContentStatus(), and the visibility
> > +        will be recomputed at a later time.
> I think it's more about trying to compute the repaint rect while in the
> middle of tree building (I looked at the stacktrace in
> rdar://problem/59355313 and did not see any layout related code)

Perhaps my phrasing is poor; when Simon, Ryosuke and I were looking at this, you're right, we weren't into  calling from layout code, but calling setHasVisibleContent() before layout has occurred was the problem.  I'm happy to rephrase this, though. :)

> > Source/WebCore/rendering/RenderElement.cpp:888
> > +            layer->dirtyVisibleContentStatus();
> I think this setHasVisibleContent() should be completely eliminated since
> the other callsite (RenderElement::styleWillChange) does not make too much
> sense either. Simon should be able to confirm this.

I'm all for removing code if not needed (and if you are correct, this would be an entire function which would not be needed?) -- but seems outside the scope of this change?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200302/ec1794c4/attachment-0001.htm>

More information about the webkit-unassigned mailing list