[Webkit-unassigned] [Bug 208442] [GTK][WPE] Fix current time and duration formatting in media controls

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=208442

Xabier Rodríguez Calvar <calvaris at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #392128|review?                     |review+, commit-queue-
              Flags|                            |

--- Comment #2 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 392128
  --> https://bugs.webkit.org/attachment.cgi?id=392128
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392128&action=review

> Source/WebCore/Modules/mediacontrols/mediaControlsAdwaita.js:411
> +        else if (duration < 10 * 60) /* Ten minutes */
> +            this.timeDigitsCount = 3;

I personally dislike having this on a time display. I would strongly recommend you remove this or run it thru more people who can give an opinion on this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200302/da2f02ed/attachment-0001.htm>