[Webkit-unassigned] [Bug 208374] [GTK][WPE] Stop using mediaControlsBase.js

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=208374

--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Xabier Rodríguez Calvar from comment #3)
> Comment on attachment 391976 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=391976&action=review
> 
> Nit: things are ok as they are now but if you feel like giving it another
> shot, I would try to use let and const instead of var. Obviously let for
> things that are going to change and const for those that are not. Your call.

I don't know JavaScript, but if it's a mechanical change I can give it a try in a follow up patch if you think it's an important change.

> > Source/WebCore/Modules/mediacontrols/mediaControlsAdwaita.js:336
> > +        this.controls.panel.classList.add(this.ClassNames.show);
> > +        this.controls.panel.classList.remove(this.ClassNames.hidden);
> 
> Nit: I think it makes more sense to switch these lines to remove the hidden
> first and then add the show.

Ok.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200302/043ed9f6/attachment-0001.htm>