[Webkit-unassigned] [Bug 208907] [GTK] graphics/GLContext.cpp fails compiling with error: ‘initializeOpenGLShims’ was not declared in this scope; did you mean ‘initializeOpenGLShimsIfNeeded’?

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=208907

Adrian Perez <aperez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aperez at igalia.com

--- Comment #7 from Adrian Perez <aperez at igalia.com> ---
(In reply to Mart Raudsepp from comment #2)
> Source/WebCore/platform/graphics/GLContext.cpp is including OpenGLShims.h
> only if GLX is enabled, but then using the initializeOpenGLShims function in
> other cases as well. I think the preprocessor conditionals should match
> better.
> As-is, it seems to guarantee a fail for a -DENABLE_X11_TARGET=OFF
> -DENABLE_OPENGL=ON build that picks OpenGL.

The ENABLE_OPENGL option does not exist, I suppose the idea is to end up
with USE_OPENGL=ON, which means setting ENABLE_GRAPHICS_CONTEXT_GL=ON.

So yes, I can reproduce the issue by configuring a build with:

  % cmake -DPORT=GTK -DENABLE_X11_TARGET=OFF -DENABLE_GRAPHICS_CONTEXT_GL=ON

> Basically initializeOpenGLShimsIfNeeded seems to think that a EGL+full
> OpenGL (instead of GLX) doesn't exist or happen, but libepoxy isn't used at
> all for a webkitgtk build (I guess it might be used in webkit-wpe or
> something)

The WPE port uses libepoxy, but the GTK port does not.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200630/15937580/attachment.htm>